[METRICS] use built-in cost functions to fetch beans #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Collection<BeanQuery> QUERIES = | ||
| Stream.of( | ||
| LogMetrics.QUERIES.stream(), | ||
| LogMetrics.QUERIES.stream(), |
There was a problem hiding this comment.
感謝！
你這個建議倒是提醒了另一件事情，你覺得我們這些內建的query中有沒有查找到重複內容？
There was a problem hiding this comment.
看起來 domain name 就不重複了，應該沒有拉到重複的內容。
另外也有實際測試過了，沒有重複。
@Test
void testing(){
try (var client = MBeanClient.jndi("localhost", 7091)){
Set<Map<String, String>> exist = new HashSet<>();
MetricFetcher.QUERIES.forEach(q -> client.beans(q).forEach(bean ->{
if (exist.contains(bean.properties())){
System.out.println(" same properties for: "+ bean.properties());
}else {
exist.add(bean.properties());
}
}));
System.out.println("All beans:"+exist.size());
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
取代原本索取全部 metrics 的設計，這邊用內建的 cost functions 的查詢條件來索取，”理論上“會少垃很多資料